Fix FFmpeg 6.0 crashes when loading 50+ clips and stressing the timeline #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
geffrak
approved these changes
Jun 5, 2024
bernie-laberge
merged commit 4639285
into
AcademySoftwareFoundation:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
483: Fix FFmpeg 6.0 crashes when loading 50+ clips and stressing the timeline
Linked issues
Fixes #483
Summarize your change.
No longer using the MovieFFMpeg global context pool (since FFmpeg 6.0)
Describe the reason for the change.
Rationale: The global context pool was based on the premise that a context could be opened and closed multiple times.
However, with FFmpeg 6.0, this premise is no longer valid and was causing crashes.
As per the FFmpeg 6 documentation: https://ffmpeg.org/doxygen/trunk/deprecated.html:
"Opening and closing a codec context multiple times is not supported anymore – use multiple codec contexts instead."
Describe what you have tested and on which operating system.
Successfully validated repro steps
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.