Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added changelog #22

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Added changelog #22

merged 1 commit into from
Jan 29, 2020

Conversation

aloysbaillet
Copy link
Contributor

Hopefully this will help everyone keep track of changes...

@aloysbaillet
Added changelog
98d017b 
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
xlietz
xlietz approved these changes Jan 29, 2020
View reviewed changes
Copy link

@xlietz xlietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful! Thanks, Aloys!

@aloysbaillet aloysbaillet merged commit 0d17262 into AcademySoftwareFoundation:master Jan 29, 2020
@jfpanisset
Copy link
Contributor

I'm a bit late, but all looks good. Would it make sense to consider explicit version tagging the repo with version tags that match the Docker Hub tags, and could also be listed in the change log? This might also allow taking advantage of the automatically generated "Releases" page.

@aloysbaillet
Copy link
Contributor Author

Thanks JF, I've been thinking about versioning and release process a bit, and as much as I'm not satisfied with what is there now, there are so many actual images that get generated that it would create quite a lot of noise in the release tab...
That said to add tags would make a lot of sense!
Would you agree tags should be added directly on master at release time by the azure pipeline job?
Would you be OK to create an issue for this? We can then discuss the details there.

@jfpanisset jfpanisset mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michdolan michdolan michdolan approved these changes

@xlietz xlietz xlietz approved these changes

@bcipriano bcipriano Awaiting requested review from bcipriano

@danrbailey danrbailey Awaiting requested review from danrbailey

@jfpanisset jfpanisset Awaiting requested review from jfpanisset jfpanisset is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aloysbaillet @jfpanisset @michdolan @xlietz