Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake issues on Windows #343

Closed
mbechard opened this issue Oct 3, 2018 · 3 comments
Closed

CMake issues on Windows #343

mbechard opened this issue Oct 3, 2018 · 3 comments
Labels
Documentation Developer guide, web site, project policies, etc. Needs Discussion To be discussed in the technical steering committee

Comments

@mbechard
Copy link

mbechard commented Oct 3, 2018

It seems like the correct way to build OpenEXR using CMake now is to use the CMake configuration that is in the root of the git tree. This is different than 2.2 and the instructions in IlmBase/OpenEXR sub directories in 2.3, which state you can use CMake from those subdirectories. When trying to do this most of the generated projects are missing since the OPENEXR_BUILD_SHARED option (and many of the other options) aren't defined at that level of the CMake, and instead are only provided in the root CMake config file. If you set them manually things seem to work out, but you'd have to know to do that by looking at the config files themselves.

I think the instructions in the subdirectories should just be removed/amended for now until this is fixed. Also the separate downloads on the webpage makes this a little confusing too, since those aren't that useful on their own for CMake builds.

Thanks

@cary-ilm cary-ilm added the CMake label Jun 13, 2019
@St0fF-NPL-ToM
Copy link

Further issues, after figuring out how to get started:
when building shared OpenEXR (i.e. the dlls), the IlmImf.dll is not correctly installed. Source seems to be the generated cmake_install.cmake script in "build/OpenEXR/IlmImf", which does not honour the install prefix correctly (regarding the dll). Comparing f.e. "build/OpenEXR/IlmImfUtil/cmake_install.cmake" shows that those lines in the script differ completely.

@cary-ilm cary-ilm added Needs Discussion To be discussed in the technical steering committee Documentation Developer guide, web site, project policies, etc. labels Jun 26, 2019
@kdt3rd kdt3rd mentioned this issue Jul 11, 2019
@kdt3rd
Copy link
Contributor

kdt3rd commented Jul 17, 2019

A complete refactor of the cmake has taken place, modernizing cmake to match the "Modern CMake" guidelines and practices, we are formalizing the install documentation to include the top-level cmake as a super project instead of first suggesting the sub directories, so this should be fixed in the next release we make (if you want to test the master branch, and report any issues with the install under windows, that would be awesome, as I primarily develop on Linux). Thanks for the report!
(I will leave this open until we finish the documentation updates)

@kdt3rd
Copy link
Contributor

kdt3rd commented Aug 13, 2019

closing as we have confirmed functionality after the refactor of cmake. If there is still an issue with master, or forthcoming release, please let us know, and thanks for the original report.

@kdt3rd kdt3rd closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Developer guide, web site, project policies, etc. Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Development

No branches or pull requests

4 participants