Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix -Wall compiler warnings #389

Closed
cary-ilm opened this issue Jun 10, 2019 · 1 comment
Closed

fix -Wall compiler warnings #389

cary-ilm opened this issue Jun 10, 2019 · 1 comment

Comments

@cary-ilm
Copy link
Member

IlmBase and OpenEXR give many warning from -Wsign-compare -Wreorder, -Wswitch, -Wunused-but-set-variable, -Wmisleading-indentation, -Wunused-function, when compiled with C++14. These should be cleaned up.
@cary-ilm cary-ilm added the C++ label Jun 13, 2019
@kdt3rd
Copy link
Contributor

kdt3rd commented Jul 23, 2019

The code base now compiles cleanly on gcc 9 using "-Wall -Wsign-compare -Wreorder -Wswitch -Wunused-but-set-variable -Wmisleading-indentation -Wunused-function" and clang 8 with similar options.

This process even found an (unreported) copy/paste bug in pyilmbase with vector 4 - the 'w' component wasn't being copied on input.

@kdt3rd kdt3rd closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdt3rd @cary-ilm