Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation : Typo in "Interpreting Deep Pixels" #623

Closed
danieldresser-ie opened this issue Nov 27, 2019 · 0 comments
Closed

Documentation : Typo in "Interpreting Deep Pixels" #623

danieldresser-ie opened this issue Nov 27, 2019 · 0 comments
Assignees
Labels
Needs Discussion To be discussed in the technical steering committee
Milestone

Comments

@danieldresser-ie
Copy link

In the document "Interpreting Deep Pixels", viewable both here:
https://github.com/AcademySoftwareFoundation/openexr/blob/master/OpenEXR/doc/InterpretingDeepPixels.pdf
and here:
https://www.openexr.com/documentation/InterpretingDeepPixels.pdf

in the equations at the top of page 11, when defining S_i,new(c) when both source alphas are <1, I'm pretty confident that the division by "w" should instead be a multiply.

Instead of:
( S_i( c ) * v_i + S_j( c ) * v_j ) / w
It should read:
( S_i( c ) * v_i + S_j( c ) * v_j ) * w

I think this must be a typo, based on comparing it to both the code for mergeOverlappingSamples at the end of the document, which uses a multiply, and also comparing to Peter Hillman's "Theory of Deep Pixels".

After referencing this document pretty frequently, but always just going to the code at the end, I think I finally understand why this page always confused me. This does seem to be one of the most useful and authoritative sources on how to work with deep images, so it would probably be worth fixing.

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Jan 9, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Development

No branches or pull requests

3 participants