Add new API call OfxSetHost #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds OfxSetHost and a few doc notes
garyo
reviewed
Sep 27, 2019
host's instead of your
garyo
reviewed
Sep 28, 2019
garyo
reviewed
Sep 28, 2019
include/ofxCore.h
Outdated
| * This host call is not specified in earlier implementation of the API. | ||
| * Therefore host must check if the plugin implemented it and not assume symbol exists. | ||
| * The order of calls is then: 1) OfxGetHost, 2) OfxGetNumberOfPlugins, 3) OfxGetPlugin | ||
| * This pointer is only assumed valid until OfxGetPlugin where it might get reset. |
garyo
reviewed
Sep 28, 2019
garyo
reviewed
Sep 28, 2019
Fixed comments as per GaryO's suggestions
Fixed a note for OfxGetHost
17 tasks
|
The documentation has not been updated for this change. However, rather than make this take even longer to merge, I'll update the doc as a separate commit after merging this shortly. |
|
See standard-change proposal at #71 |
|
Note that this has not been merged into master -- only onto a feature branch, pending resolution of open questions and final approval. |
garyo
added a commit
that referenced
this pull request
Apr 19, 2020
garyo
added a commit
that referenced
this pull request
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OfxSetHost and a few doc notes
Please read the contribution guidelines.
Description
Please provide a description of what this PR is meant to fix, and link it to the corresponding open issue with its tag.
Also explain how it works (if it's not going to be very clear from the code).