ofxImageEffect.h - Desired Premult #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Property defines an host level policy. So effects receiving an ImageOpaque and Generator know to be Premult or Straight if they don't generate a full Alpha.
Added clarification of interaction between kOfxImageEffectPropPreMultiplication clip preference and state of a particular instance regarding kOfxImageEffectHostDesiredPremult
garyo
reviewed
May 5, 2020
include/ofxImageEffect.h
Outdated
|
|
||
| - Type - string X 1 | ||
| - Property Set - a plugin instance (read only) | ||
| - Default - 0 | ||
| - Property Set - a plugin instance (read only). Ideally this information should already be available at parameter creation stage. |
There was a problem hiding this comment.
I don't think we should add comments like "Ideally". Just "should" or "must". Who would be helped by this change?
garyo
reviewed
May 5, 2020
include/ofxImageEffect.h
Outdated
| Valid Values - This must be one of | ||
|
|
||
| - kOfxImagePreMultiplied - the image is premultiplied by its alpha | ||
| - kOfxImageUnPreMultiplied - the image is unpremultiplied | ||
|
|
||
| This Property defines an host level policy. | ||
| This Property defines an host level policy. It is for practical purposes considered global in the scope of a Project. |
There was a problem hiding this comment.
When you say "It is for practical purposes considered global" are you really saying that a host should (or must) not change its value? If so, do you mean it must be constant per plugin instance, constant for all instances of a given plugin, or what? And why? Why couldn't a host pass different values to different instances?
garyo
reviewed
May 5, 2020
include/ofxImageEffect.h
Outdated
| This Property defines an host level policy. | ||
| This Property defines an host level policy. It is for practical purposes considered global in the scope of a Project. | ||
|
|
||
| Recommended Interpretation: If an host adds support for OfxImageEffectHostDesiredPremult, the host should set on the output the same value on output clip kOfxImageEffectPropPreMultiplication preference |
There was a problem hiding this comment.
This needs some grammar work.
There was a problem hiding this comment.
:) - upping the standard now
Also should not say Recommended but Expected here I guess
Fixes comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Property defines an host level policy. So effects receiving an ImageOpaque and Generator know to be Premult or Straight if they don't generate a full Alpha. See Standard Change issue #66.