Introduce NanoVDB

[kmuseth]

Signed-off-by: Ken ken.museth@gmail.com

[Idclip]

Some initial structure thoughts before I take a closer look:

• The CI is written using circle. It'll need to be ported to a .github/workflows/nanovdb.yml and made to work with github actions. We'll also need CI which tests building/configuring OpenVDB and NanoVDB together
• The copied CMake files in nanovdb/cmake can be removed and we should use the ones in the root cmake folder. This includes the ones for IlmBase, OpenVDB, TBB, Blosc, Utils and GLFW3. Additionally is there a reason we have modules for finding OpenGL and EGL? CMake comes with these.
• There's no build support for NanoVDB from the root directory of the repo. This should be added and needs to include things like the doxygen documentation (which should work with VDBs docs), unit tests and examples as well as the core NanoVDB "lib".
• If the docker stuff is primarily designed for the CI then I would recommend we move it to the CI folder to only provide the public essentials in /nanovdb
• I propose we nest the nanovdb directory in a similar fashion to all the other modules i.e. nanovdb/nanovdb/<stuff>. This will allow us to use NanoVDB in the OpenVDB Houdini and OpenVDB AX modules and will prevent issues down the line with ambiguous include paths should we add anything else that depends on nanovdb.

[apradhana]

@kmuseth should this file be deleted since it should be generated by cmake?

[OpenVDB-DevTeam]

actually no - this file is a Makefile that I created manually - cmake generates another Makefile in a separate build library. However, the argument could be made that we only support cmake and not gmake as in OpenVDB :) We can discuss this at the next TSC meeting

…

On Wed, Aug 25, 2021 at 1:47 PM apradhana ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In nanovdb/Makefile <#1139 (comment)> : > @@ -0,0 +1,616 @@ +# Copyright Contributors to the OpenVDB Project @kmuseth <https://github.com/kmuseth> should this file be deleted since it should be generated by cmake? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1139 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALVUPZNIJ7Q4TZHBN3CBY3T6VJGDANCNFSM5BN5PL2A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[danrbailey]

Closing this PR to avoid confusion - feature/nanovdb will remain a separate branch for anyone already working from this branch, but NanoVDB will be merged to master separately (#1213) and then this feature branch subsequently updated.