CMake/Documentation/Python/CI fixes and improvements #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Idclip
commented
Oct 30, 2021
Idclip
commented
- Disable explicit instantiation on various CI jobs
- Disable pkg_config on windows by default
- Improved build and dependency documentation
- Improved changelogs
- Improved python/CMakeLists.txt (also fixes [BUILD] Issue finding NumPy with several Python installed. #1226)
…where NumPy needs to be specified along with the Development and Interpreter components in a single call Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
Idclip
requested review from
apradhana,
danrbailey,
jmlait,
kmuseth and
richhones
as code owners
Idclip
commented
Oct 30, 2021
| Log4cplus | 1.1.2 | Latest | An optional dependency for improved OpenVDB Logging | Y | Y | https://github.com/log4cplus/log4cplus | ||
| libpng | - | Latest | Library for manipulating PNG images | Y | Y | http://www.libpng.org/pub/png/libpng.html | ||
| GLFW | 3.1 | Latest | Simple API for OpenGL development | Y | Y | https://www.glfw.org | ||
| OpenGL | 3.2 | Latest | Environment for developing portable graphics applications | Y | Y | https://www.opengl.org | ||
| GLEW | 1.0.0 | Latest | A cross-platform OpenGL extension loading library. | Y | Y | http://glew.sourceforge.net | ||
| CUDA | - | Latest | Parallel computing platform for graphical processing units. | Y | N | https://developer.nvidia.com/cuda-downloads |
There was a problem hiding this comment.
@kmuseth do we have a minimum supported CUDA version for nanovdb?
Idclip
commented
Oct 30, 2021
| else() | ||
| list(APPEND OPENVDB_PYTHON_DEPS Python::Python) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Python::Module always exists from CMake 3.15
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
danrbailey
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.