Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off USE_EXPLICIT_INSTANTIATION on Windows by default #1721

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Turn off USE_EXPLICIT_INSTANTIATION on Windows by default #1721

merged 1 commit into from
Jan 18, 2024

Conversation

Idclip
Copy link
Contributor

@Idclip Idclip commented Dec 6, 2023 •
edited
Loading

@Idclip
Turn off USE_EXPLICIT_INSTANTIATION on Windows by default
beb1d0b 
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
@Idclip Idclip enabled auto-merge December 6, 2023 21:20
danrbailey
danrbailey reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@danrbailey danrbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a first step is to just disable it when building static libs on Windows?

@danrbailey
Copy link
Contributor

Maybe a first step is to just disable it when building static libs on Windows?

Never mind, we can come back and make that additional change later.

@Idclip Idclip merged commit b51fce1 into AcademySoftwareFoundation:master Jan 18, 2024
39 of 41 checks passed
@Idclip Idclip deleted the explicit_instantiation_windows branch January 18, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrbailey danrbailey danrbailey approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

@apradhana apradhana Awaiting requested review from apradhana apradhana is a code owner

@jmlait jmlait Awaiting requested review from jmlait jmlait is a code owner

@richhones richhones Awaiting requested review from richhones richhones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Idclip @danrbailey