override git plugin config in package.py

[alexxbb]

What is the proper way of overriding allow_no_upstream config property in package.py?

I found this code

And tried various ways with no success:

with scope("config") as c:
    c.plugins.release_vcs.git.allow_no_upstream = True

# found this in some of the test files, it fails with an error
with scope("config") as c:
    c.override("plugins.release_vcs.git.allow_no_upstream", True)

with scope("plugins"):
  with scope("release_vcs"):
    with scope("git"):
      allow_no_upstream = True

[nerdvegas]

Hey, I can't repro this unfortunately, it's working for me (using the first form listed). What os/rez-version? What was the specific error message you got?

[alexxbb]

Hi Allan,
I'm getting this error:

ReleaseVCSError: command failed: /usr/bin/git rev-parse --abbrev-ref --symbolic-full-name '@{u}'
fatal: HEAD does not point to a branch

rez-release --skip-repo-errors works, I thought I keep the settings within the package.py
This is needed for a release with a gitlab CI job, it checks out a tag, and therefore the HEAD is missing.

>> rez --version
Rez 2.53.1
>>python --version
Python 2.7.5

CentoOS 7

We have REZ_CONFIG_FILE point to our studio config, and there is a plugins dictionary with just the emailer plugin configured, I tried this too, but got the same error.

env REZ_CONFIG_FILE="" rez-release

# -*- coding: utf-8 -*-
name = '...'
version = '1.6.12'
authors = []

requires = []
variants = [['houdini-18.0', 'python-2']]
private_build_requires = ['fxBuildTools-4']

with scope("config") as c:
    c.release_packages_path = "/shots/fx/home/software/packages"
    c.plugins.release_hook.emailer.recipients = []
    c.plugins.release_vcs.git.allow_no_upstream = True

def commands():
    env.HOUDINI_PATH.prepend("{root}/houdini")
    env.PATH.prepend("{root}/bin")
    env.PYTHONPATH.prepend("{root}/python")


uuid = '173c976d-43f4-460f-924b-0abbb41a04e1'

[alexxbb]

Also this:

with scope("config") as c:
    print(c.plugins)

{'release_hook': {'emailer': {'recipients': ['xxx@imageworks.com']}}}

[nerdvegas]

So I think you're hitting an error earlier than the code that's checking the allow_upstream config setting. See: https://github.com/nerdvegas/rez/blob/master/src/rezplugins/release_vcs/git.py#L78 This is getting called before L98, and causes the error you've given here if a tag is checked out. I'm a bit puzzled as to how this hasn't come up before though. The fix seems straightforward - just add a check for 'does not point to a branch' substring on L85. Are you able to build a local rez instance and try this out? This ticket also makes me think we should add a PKG option to the rez-config tool so you can see a config dump wrt a given developer package. Thx A

…

On Fri, Apr 3, 2020 at 3:33 AM alexxbb ***@***.***> wrote: Also this: with scope("config") as c: print(c.plugins) {'release_hook': {'emailer': {'recipients': ***@***.***']}}} — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#871 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMOUSSLLFXYBFF4LMXCF33RKS44FANCNFSM4LZY5H2A> .