fixed missing __ne__ op in resource handle #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been there a long time, undetected.
Manifested as rez-test not being able to find the correct variant to run a test in, because a (VariantHandle != VariantHandle) test was always returning True despite the handles being equivalent. This started happening because in v2.84.0, a change was made where the handle returned from installing a variant into a filesystem repo, was changed to return it from a copy of the repo. See https://github.com/nerdvegas/rez/pull/1061/files#diff-0923f674fb98267b2cbc6111a14e4073edceab2b1b2661939dfef8bf7f112dbcR1341-R1346 for an explanation of why we do this.
Fixes #1095