Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address following two issues.
Can't check if env contains var with keyword
in
In
package.py
, this won't workBecause
"FOO" in env
or"FOO" in env.keys()
always returnTrue
, no matter the env actually contains the var or not.Commit ffbbfbc fixed this.
Can't use keyword
or
to get default valueSometimes I'd like to set default value like this
But if key "FOO" not in env,
RexUndefinedVariableError
is raised.In regular
dict
, theget()
method can take default value if the key not exists. However, theEnvironmentDict.__getitem__
always return anEnvironmentVariable
instance, so the default value never had a chance. So the alternative is usingor
. But if key not exists, error raised when it's being evaluated inEnvironmentVariable.__bool__()
method.I think
__bool__
should never raise error, hence 658322f.