Issue 1214 spdx enforce #1215
Merged
Issue 1214 spdx enforce #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/copyright.yaml
Outdated
| exit 1 | ||
| fi | ||
| env: | ||
| IN_GITHUB_WORKFLOW: 1 |
There was a problem hiding this comment.
The environment variable GITHUB_ACTIONS is provided by GitHub Actions for exactly this purpose. See https://docs.github.com/en/actions/learn-github-actions/environment-variables#:~:text=example%2C%20actions/checkout.-,GITHUB_ACTIONS,-Always%20set%20to.
|
Cool @ GITHUB_ACTIONS, didn't know about that one.
Re py3, I agree, but there's a few cases of this, probably better addressed
in separate PR(s):
- pypi
- sphinx
- copyright
Perhaps we also advance to 3.10 as default 3.x version at the same time. So
a general py3-workflows PR is probably justified. Added ticket:
#1216
Lastly, Windows workflow currently has py3 disabled, I don't recall why
this was. Will need to investigate and reenable.
A
…On Wed, Feb 16, 2022 at 8:20 AM Jean-Christophe Morin < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/copyright.yaml
<#1215 (comment)>:
> + - 'src/**'
+ - '!**.md'
+
+jobs:
+ main:
+ name: Enforce copyright notices
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout
+ uses: ***@***.***
+
+ - name: Set up Python
+ uses: ***@***.***
+ with:
+ python-version: 2.7
Should we use Python 3 here? The script looks quite simple, I'm sure it
wouldn't be *that* much effort to port.
—
Reply to this email directly, view it on GitHub
<#1215 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOUSS3IVNQYIHU4HYRXNDU3K7R3ANCNFSM5OPXCRHQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1214