Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nerdvegas with aswf #1368

Merged

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Aug 28, 2022

This is almost, but not quite closing:
#1205

The remaining items to evaluate or potentially change are:
src/rezgui/__init__.py:5:organisation_name = "nerdvegas"
setup.py:65: author_email="nerdvegas@gmail.com",
and sonarcloud project refs, that have a separate ticket I don't have permissions to address.

please note: references to the "author" nerdvegas, or the project nerdvegas/rez-shotgun have been retained. Anything that currently properly forwards to the ASWF repo has been updated, including changelog entries, as potentially unnecessary as it might be.

Nothing else should need scrubbing, apart from the 3 items mentioned above, potentially.

@maxnbk maxnbk requested a review from nerdvegas as a code owner August 28, 2022 22:06
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
@JeanChristopheMorinPerso
Copy link
Member

The author email can be replaced with rez-discussion@lists.aswf.io which is the email of the ASWF hosted mailing list. That's what the other ASWF projects do (https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/setup.cfg#L3, https://github.com/AcademySoftwareFoundation/OpenTimelineIO/blob/main/setup.py#L198).

As for the organization name, why not ASWF? Or simply drop the organization name.

Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
@maxnbk
Copy link
Contributor Author

maxnbk commented Aug 28, 2022

updated those two refs

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maxnbk maxnbk merged commit 71f2f61 into AcademySoftwareFoundation:master Aug 29, 2022
@maxnbk maxnbk deleted the replace-nerdvegas-with-aswf branch August 29, 2022 15:28
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the 2.112.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants