Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error caused by weakly referenced package not specifying version … #1712

Merged

Conversation

loonghao
Copy link
Contributor

@loonghao loonghao commented Apr 8, 2024

This PR is try to fix #1711

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.29%. Comparing base (9610630) to head (341eb1f).

❗ Current head 341eb1f differs from pull request most recent head 75dd459. Consider uploading reports for the commit 75dd459 to get more accurate results

Files Patch % Lines
src/rez/package_order.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
+ Coverage   58.27%   58.29%   +0.01%     
==========================================
  Files         126      126              
  Lines       17157    17159       +2     
  Branches     3504     3505       +1     
==========================================
+ Hits         9998    10002       +4     
+ Misses       6494     6493       -1     
+ Partials      665      664       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Apr 8, 2024
@JeanChristopheMorinPerso
Copy link
Member

@loonghao loonghao force-pushed the fix_1711 branch 4 times, most recently from db85913 to 86553da Compare April 9, 2024 05:42
@loonghao
Copy link
Contributor Author

loonghao commented Apr 9, 2024

@loonghao Thanks for creating this PR. Do you think you could add a test for these lines: https://github.com/AcademySoftwareFoundation/rez/pull/1712/files#diff-1ad6984e6ce49221a86620d55092bacae0b32b2d6c9401295c655c9d3e72a1a0R443-R446?

@JeanChristopheMorinPerso
I adjusted some tests and found that I still couldn't cover these lines of code.
I think since they are all expected they won't raise a TypeError, I removed the update on these lines.

src/rez/solver.py Outdated Show resolved Hide resolved
@loonghao loonghao force-pushed the fix_1711 branch 3 times, most recently from 027c47f to e3c07bd Compare April 10, 2024 06:37
src/rez/package_order.py Outdated Show resolved Hide resolved
…range

Signed-off-by: loonghao <hal.long@outlook.com>
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @loonghao and @isohedronpipeline!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 8decb45 into AcademySoftwareFoundation:main Apr 13, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error caused by weakly referenced package not specifying version range
3 participants