Don't expand tilde in REZ_USED_IMPLICIT_PACKAGES and REZ_USED_REQUEST environment variables #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: do not perform tilde expandsion on REZ_USED_IMPLICIT_PACKAGES
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
==========================================
- Coverage 58.41% 58.40% -0.01%
==========================================
Files 126 126
Lines 17163 17165 +2
Branches 3506 3506
==========================================
+ Hits 10025 10026 +1
- Misses 6473 6474 +1
Partials 665 665 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Thanks for submitting this PR @cfxegbert! It looks good to me. Though, I'm wondering if we should be more aggressive and do the same with the other variables too or at least on REZ_USED_REQUEST since it's totally valid to do rez-env mypackage '~otherpackage'.
Signed-off-by: Jean-Christophe Morin <38703886+JeanChristopheMorinPerso@users.noreply.github.com>
|
Pushed a change to make |
JeanChristopheMorinPerso
changed the title
JeanChristopheMorinPerso
merged commit 704eb71
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1717