Issue 549

[nerdvegas]

2.26.0 Build System Detection Fixes

Addressed Issues

• #549 '--build-system' rez-build option not always
  available

Notes

To fix this issue:

• The '--build-system' rez-build option is now always present.
• To provide further control over the build system type, the package itself can now specify its build
  system - see https://github.com/nerdvegas/rez/wiki/Package-Definition-Guide#build_system

COMPATIBILITY ISSUE!

Unfortunately, the 'cmake' build system had its own '--build-system' commandline option also. This
was possible because previous rez versions suppressed the standard '--build-system' option if only
one valid build system was present for a given package working directory. This option has been
changed to '--cmake-build-system'.

[fnaum]

this needs
dest="cmake_build_system",

If not when running with --bs it won't be picked in line 96

[nerdvegas]

Fix included in https://github.com/nerdvegas/rez/releases/tag/2.29.1 Cheers A

…

On Wed, Apr 17, 2019 at 3:55 PM Federico Naum ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/rezplugins/build_system/cmake.py <#550 (comment)>: > @@ -75,8 +75,8 @@ def bind_cli(cls, parser): type=str, choices=cls.build_targets, default=settings.build_target, help="set the build target (default: %(default)s).") - parser.add_argument("--bs", "--build-system", dest="build_system", - type=str, choices=cls.build_systems.keys(), + parser.add_argument("--bs", "--cmake-build-system", this needs dest="cmake_build_system", If not when running with --bs it won't be picked in line 96 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#550 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjqSi8qYVfKXj41-QXlnok1vDb8uFcbks5vhrdQgaJpZM4ZS4-h> .