Implement preprocess function support for rezconfig.py (takeover) #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2019
|
Perfect thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to define a function for
package_preprocess_functiondirectly in therezconfig.py.This is a new PR that takes the commits from #597. Why a new PR? Because mainly I couldn't push to the previous PR (due to permission issues) and @mottosso suggested to just take his commits and open a new PR.
What's new in this PR? I addressed the comments from #597 and I also added tests for the new behavior.
@nerdvegas #597 can be closed in favor of this current PR.