-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix py3 errors and warnings #748
Fix py3 errors and warnings #748
Conversation
The decode commit is causing this, for me, on linux, with python-3.6.1.
|
That is extra weird... Maybe we could force convert it to a byte string? |
This isn't a result of your changes, but I'm noticing a warning I was missing because it's not failing any tests, but is appearing very far at the top of the tests, specifically for the portion of tests run by
|
Yeah, this one I already saw it. It's simply due to how the test is written. The same happens in python 2. I'll commit a fix for this as it's annoying. |
This is a batch of commits that fixes errors and warnings that we have in the master branch. Each commit contains a unique change.
collections.MutableMapping
is deprecated and it will stop to work in Python 3.8. The import needs to becollections.abc.MutableMapping
instead.MutableMapping
in python 3, we need to re-implement the abstract methods__delitem__
,__iter__
and__len__
.rezconfig.py
that was to do with a\
in the docstring.platform_
due to the methoddecode
that doesn't exit on typestr
in python 3.imp
is deprecated in Python 3. So I changed it to useimportlib
when in python 3.I ran the tests under Linux with python 2.7, 3.4, 3.5, 3.6 and 3.7. If someone could confirm that everything is working in Windows, that would be great.
The only change I'm not sure of is the
decode
. No comments was made in the commit that introduced it to explain why it was needed.Once that is merged, I'll do a pass at updating the vendored libs that cause other warnings.