Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_build_cmake on Windows. #772

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Skip test_build_cmake on Windows. #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,12 @@ like any other package:
* Has a memcached-based caching system, for caching environment resolves;
* Has a package filtering feature, allowing for staged package releases such as
alpha and beta packages.

## Known issues and limitations

* Currently CMake builds do not function on Windows with Rez and
the related tests are skipped. A fix requires multiple changes that are on
the roadmap. Users have successfully implemented workarounds to utilize
CMake with Rez under Windows, but the goal is to provide a seamless experience
on any platform in the future. For details checkout
https://github.com/nerdvegas/rez/issues/703
6 changes: 6 additions & 0 deletions src/rez/tests/test_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import unittest
from rez.tests.util import TestBase, TempdirMixin, find_file_in_path, \
per_available_shell, install_dependent, program_dependent
from rez.utils.platform_ import platform_
import shutil
import os.path

Expand Down Expand Up @@ -155,6 +156,11 @@ def test_builds_anti(self):
@program_dependent("cmake")
def test_build_cmake(self):
"""Test a cmake-based package."""
if platform_.name == "windows":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could potentially do:

    @unittest.skipIf(platform_.name == "windows", "This ...")
    @program_dependent("cmake")
    def test_build_cmake(self):
        """Test a cmake-based package."""

Would that work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this anyway, given that it's a temporary measure. If it works then it works - better to get traction on the source of the problem (and yes Blazej I will get up to speed on that ticket soon).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @JeanChristopheMorinPerso.
I just took it from some other location that does it with a condition, so we might want to unify all of them.
But it's also true that we should try to get rid of these guys completely :)

self.skipTest("This test does not run on Windows due to temporary"
"limitations of the cmake build_system plugin"
" implementation.")

self.assertRaises(PackageFamilyNotFoundError, self._create_context,
"sup_world==3.8")
self._test_build_translate_lib()
Expand Down