Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actions badges in README #786

Closed
wants to merge 3 commits into from
Closed

Updated actions badges in README #786

wants to merge 3 commits into from

Conversation

j0yu
Copy link
Contributor

@j0yu j0yu commented Nov 6, 2019

Closes #785

Updated README.md badges:

Core
Ubuntu
MacOS

  • Change badges to only show for master branch runs
  • Added/fixed missing Windows workflows
  • Added links to workflows pages for each badge
  • Added alt text to each badge image

Edits:

  1. Removed from PR: Compose Windows Docker Image

  2. Let Improvements on Windows Tests #789 implement Windows

    [![Windows](https://github.com/nerdvegas/rez/workflows/Windows/badge.svg?branch=master)](https://github.com/nerdvegas/rez/actions?query=workflow%3A%22Windows%22+branch%3Amaster)`

@bfloch
Copy link
Contributor

bfloch commented Nov 6, 2019

Not sure if we need to expose the Composing badge. It is just a utility workflow that enables the "Windows Docker" workflow and in best case we will only touch it once.

EDIT: More context - it will only trigger if the image related workflows/dockerfiles are touched. It does not add any information to the state of rez passing builds/tests.

README.md Outdated Show resolved Hide resolved
@j0yu j0yu closed this Nov 6, 2019
@j0yu j0yu reopened this Nov 6, 2019
@nerdvegas
Copy link
Contributor

I was also going to suggest that we move back to naming the workflow "Windows" rather than "Windows Docker" (use of docker for the test is an implementation detail). I didn't want to make that change at the same time as merging Blazej's PR though.

@nerdvegas nerdvegas mentioned this pull request Nov 7, 2019
10 tasks
@j0yu
Copy link
Contributor Author

j0yu commented Nov 8, 2019

Ok, I'll let #789 handle the Windows badge. I've reverted it in this PR so hopefully the merges will be cleaner

I'll leave this snippet here @bfloch for #789

[![Windows](https://github.com/nerdvegas/rez/workflows/Windows/badge.svg?branch=master)](https://github.com/nerdvegas/rez/actions?query=workflow%3A%22Windows%22+branch%3Amaster)`

@nerdvegas
Copy link
Contributor

Merged in https://github.com/nerdvegas/rez/releases/tag/2.47.13

@nerdvegas nerdvegas closed this Nov 8, 2019
@j0yu j0yu deleted the docs-readme-badges branch November 8, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix README actions badges not showing current master status
3 participants