Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose package orderers in rez config #868

Conversation

rlessardrodeofx
Copy link
Contributor

This PR add a package_orderers entry in the rez config. Fixes #329.

This allow package orders to be configured.
We deployed this at RodeoFX 6 month ago and had no issues.
Our use case was to set a per_facility orderer so that rez "prefer" python 2 over python 3 by default.

Here's what our configuration look like:

package_orderers:
- orderers:
  - first_version: 2.7.16-r999
    packages:
    - python
    type: version_split
  type: per_family

Changes

  • Added "package_orderers" entry in rez config
  • Add a convenience class PackageOrderList (similar to PackageFilterList)
  • Fix a serialization issue with VersionSplitPackageOrder (second point in Orderer fixes #413)
  • Create a dedicate test_package_orders.py for package orderers tests (100% branch coverage on package_orderers.py. Note that test_9 in test_packages.py was moved into individual per-family tests.
  • Minor: Make the TimestampPackageOrder rank default to 0 if unset

@JeanChristopheMorinPerso
Copy link
Member

I (I work with @renaudll) confirm that we have been using this for 6 months and it's been working fine.

@nerdvegas nerdvegas merged commit f616b5d into AcademySoftwareFoundation:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add configurability of package orderers
3 participants