Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling build/install directory remove error in build process #959

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Handling build/install directory remove error in build process #959

merged 3 commits into from
Oct 5, 2020

Conversation

davidlatwe
Copy link
Contributor

Problem

In the following cases, plain shutil.rmtree may have trouble removing a directory :

  • Path length is over 259 characters (on Windows)
  • Path contains Unicode character (using Python 2)
  • File is read-only (e.g. some git internal files in .git folder, if build dir contains one)

This PR aims to overcome those issues and to ensure build/install directory can be removed entirely by Rez when we need it to.

@nerdvegas nerdvegas merged commit c46fab0 into AcademySoftwareFoundation:master Oct 5, 2020
@davidlatwe davidlatwe deleted the handle_dir_remove_err_in_build branch November 17, 2020 06:10
@davidlatwe davidlatwe mentioned this pull request Jan 15, 2021
Merged
@JeanChristopheMorinPerso JeanChristopheMorinPerso mentioned this pull request May 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidlatwe @nerdvegas