Add Deposit for Setting Alternative Fee Swap Path #1730

ferrell-code · 2021-12-24T06:13:12Z

Deposit prevent bloated chain state

ferrell-code · 2021-12-24T06:18:38Z

/bench runtime acala module_transaction_payment

ghost · 2021-12-24T06:18:40Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Acala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 41.01
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 41.01
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 12.53
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 12.53
µs

Reads = 2
Writes = 1

…hmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

ferrell-code · 2021-12-24T06:29:37Z

/bench runtime karura module_transaction_payment

ghost · 2021-12-24T06:29:38Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 38.11
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 38.11
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 12.53
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 12.53
µs

Reads = 2
Writes = 1

ferrell-code · 2021-12-24T06:32:32Z

/bench runtime mandala module_transaction_payment

…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

ghost · 2021-12-24T06:35:22Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Mandala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 40.16
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 40.16
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 12.46
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 12.46
µs

Reads = 2
Writes = 1

…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

xlc

need a different RESERVE_ID to avoid mixing them

modules/transaction-payment/src/lib.rs

…AcalaNetwork/Acala into fer-deposit-transaction-payment

ferrell-code · 2021-12-24T20:02:19Z

/bench runtime acala module_transaction_payment

ghost · 2021-12-24T20:02:21Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Acala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 44.24
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 44.24
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 13.4
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 13.4
µs

Reads = 2
Writes = 1

…hmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

ferrell-code · 2021-12-24T21:34:29Z

/bench runtime karura module_transaction_payment

ghost · 2021-12-24T21:34:31Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 41.74
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 41.74
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 12.56
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 12.56
µs

Reads = 2
Writes = 1

ferrell-code · 2021-12-24T21:36:24Z

/bench runtime mandala module_transaction_payment

…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

ghost · 2021-12-24T21:40:17Z

Finished benchmark for branch: fer-deposit-transaction-payment

Benchmark: Benchmark Runtime Mandala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

Results

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: Balances Reserves (r:1 w:1)
Storage: TransactionPayment AlternativeFeeSwapPath (r:0 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 52.62
µs

Reads = 1
Writes = 2

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 52.62
µs

Reads = 1
Writes = 2

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPayment NextFeeMultiplier (r:1 w:1)
Storage: System BlockWeight (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 23.55
µs

Reads = 2
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 23.55
µs

Reads = 2
Writes = 1

…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_payment --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

modules/transaction-payment/src/lib.rs

…AcalaNetwork/Acala into fer-deposit-transaction-payment

* origin/master: (102 commits) Fix collect_fee (#1754) Update HEADER-GPL3 Update extrinsic-ordering-check-from-bin.yml (#1752) Update HEADER-GPL3 bump version (#1751) Remove homa-lite from karura runtime (#1744) off-by-one (#1747) Revert "simulate exchange rate (#1742)" (#1746) simulate exchange rate (#1742) bump version (#1743) refactor homa (#1648) Update stable asset (#1741) add more info to events (#1740) Fix mandala swap path error (#1736) update stable asset (#1738) remove unnecessary code (#1735) fix currency id testing (#1733) rework fee payment (#1687) Add Deposit for Setting Alternative Fee Swap Path (#1730) Add register_erc20_asset and update_erc20_asset (#1731) ... # Conflicts: # .github/workflows/coverage.yml.disabled # Cargo.lock # Cargo.toml

ferrell-code added 3 commits December 24, 2021 00:51

initial fix

495eafa

update mock

7328235

benchmark

dad7925

xlc requested changes Dec 24, 2021

View reviewed changes

modules/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

modules/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

xlc mentioned this pull request Dec 24, 2021

Ability to remove alternative fee swap path for account without ED #1732

Open

ferrell-code added 3 commits December 24, 2021 13:40

new ReserveIdentifier, other review suggestions

bef71d4

Merge branch 'fer-deposit-transaction-payment' of https://github.com/…

93fe44f

…AcalaNetwork/Acala into fer-deposit-transaction-payment

fmt

8dd6ac7

xlc reviewed Dec 25, 2021

View reviewed changes

modules/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved

ferrell-code added 2 commits December 25, 2021 12:38

rename BalanceOf

f4d5b95

Merge branch 'fer-deposit-transaction-payment' of https://github.com/…

942d0c5

…AcalaNetwork/Acala into fer-deposit-transaction-payment

xlc approved these changes Dec 26, 2021

View reviewed changes

ferrell-code merged commit 6c7c3c0 into master Dec 27, 2021

ferrell-code deleted the fer-deposit-transaction-payment branch December 27, 2021 00:30

Add Deposit for Setting Alternative Fee Swap Path #1730

Add Deposit for Setting Alternative Fee Swap Path #1730

Conversation

ferrell-code commented Dec 24, 2021

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

xlc left a comment

Choose a reason for hiding this comment

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ferrell-code commented Dec 24, 2021

ghost commented Dec 24, 2021 • edited by ghost Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Dec 24, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_payment", Extrinsic: "set_alternative_fee_swap_path", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_payment", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info