Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math #1754

Merged
merged 1 commit into from
Jan 6, 2022
Merged

math #1754

merged 1 commit into from
Jan 6, 2022

Conversation

ukby1234
Copy link
Contributor

@ukby1234 ukby1234 commented Jan 6, 2022

Fix collect_fee

cc @shengda

@ukby1234 ukby1234 requested a review from xlc January 6, 2022 07:04
@ukby1234 ukby1234 enabled auto-merge (squash) January 6, 2022 07:04
@ukby1234
Copy link
Contributor Author

ukby1234 commented Jan 6, 2022

This is to fix total supply can go down temporarily because of rounding errors in balance conversion.

@xlc
Copy link
Member

xlc commented Jan 6, 2022

It will be better if the stable assets side have more test

@ukby1234 ukby1234 merged commit b8e0d02 into master Jan 6, 2022
@ukby1234 ukby1234 deleted the math branch January 6, 2022 08:04
syan095 pushed a commit that referenced this pull request Jan 7, 2022
* origin/master: (102 commits)
  Fix collect_fee (#1754)
  Update HEADER-GPL3
  Update extrinsic-ordering-check-from-bin.yml (#1752)
  Update HEADER-GPL3
  bump version (#1751)
  Remove homa-lite from karura runtime (#1744)
  off-by-one (#1747)
  Revert "simulate exchange rate (#1742)" (#1746)
  simulate exchange rate (#1742)
  bump version (#1743)
  refactor homa (#1648)
  Update stable asset (#1741)
  add more info to events (#1740)
  Fix mandala swap path error (#1736)
  update stable asset (#1738)
  remove unnecessary code (#1735)
  fix currency id testing (#1733)
  rework fee payment (#1687)
  Add Deposit for Setting Alternative Fee Swap Path (#1730)
  Add register_erc20_asset and update_erc20_asset (#1731)
  ...

# Conflicts:
#	.github/workflows/coverage.yml.disabled
#	Cargo.lock
#	Cargo.toml
syan095 pushed a commit that referenced this pull request Jan 13, 2022
* origin/master: (53 commits)
  add new audit report
  Use ExitReason::Revert instead of ExitReason::Error (#1772)
  Claim Account to use Eip-712 (#1755)
  Benchmark evm (#1674)
  support evm create rpc and allow H160 default (#1771)
  Update template files license header. (#1770)
  Fix collect_fee (#1766)
  handle nonce for eth tx (#1707)
  updated to the ORML's test coverage file (#1760)
  rm runtime upgrade (#1757)
  Happy new year 2022. (#1761)
  Excluded some files from test coverage (#1759)
  XCM: add deposit error handler for multi-currency adapter. (#1756)
  update stable asset (#1758)
  Fix test coverage for acala (#1590)
  Fix collect_fee (#1754)
  Update HEADER-GPL3
  Update extrinsic-ordering-check-from-bin.yml (#1752)
  Update HEADER-GPL3
  bump version (#1751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants