Use representation types for expressions and shapes #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix true / false patterns
It accidentally consisted of zeros instead of -1
|
GHC 8.8 doesn't believe anymore that the type family |
&& and || are now defined in terms of if-then-else &&! and ||! are strict variants of them, which do not short circuit
…nto refactor-expression-tuples
tomsmeding
reviewed
May 13, 2020
src/Data/Array/Accelerate/Type.hs
Outdated
| type Tup8 a b c d e f g h = (((((((((), a), b), c), d), e), f), g), h) | ||
| type Tup9 a b c d e f g h i = ((((((((((), a), b), c), d), e), f), g), h), i) | ||
| type Tup16 a b c d e f g h | ||
| i j k l m n o p = ((((((((((((((((((), a), b), c), d), e), f), g), h), i), j), k), l), m), n), o), p)) |
There was a problem hiding this comment.
I believe there is a redundant pair of outer parentheses here :)
There was a problem hiding this comment.
Thanks, good catch!
8 tasks
Previously defined in accelerate-llvm
This may duplicate work
8 tasks
tmcdonell
added a commit
to tmcdonell/accelerate
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, the types of expressions would refer to surface types. This PR changes that: internally the type now regards the representation type, similar to what I did previously on Acc in #449. A quick summary of the changes:
Exp,PreOpenExpfromAST.hsregards representation types.Smart.hs, we introducedSmartExpto capture the recursion. Its type argument regards representation types. To hide this change to the user, we wrap this innewtype Exp t = Exp (SmartExp (EltRepr t)).PairandNil.Vec n t) are now more explicit in the AST. Creating vectors or extracting data from them is achieved by converting the vector from/to a tuple. This is done usingVecPackandVecUnpack.V2_,V3_,V4_,V8_andV16_Pattern.hsElt (Vec n t)for different single types, we have now have only one instance. We use type classVecEltto denote which single types can be stored in a Vec.Complexcan be used on all types instead of only floating point numbers.Motivation and context
This change should make the internals of Accelerate easier, as it is easier to reason in terms of representation types, and in terms of variables of a scalar type.
How has this been tested?
The tests are all passing :)
Types of changes
Checklist: