Remove dependency on 'anaphora' + some portability fixes #15
Conversation
This fixes the warning related to the test system name and removes some boilerplate that isn't required anymore.
It seems that cl-interpol is not used by access.
All uses can be replaced by IF-LET and WHEN-LET from alexandria without increasing code size.
Since cl-user is explicitly meant for 'user things', it can cause name conflicts at any time. There is no need to import its symbols into the access package.
This changes all uses of alexandria symbols to use a consistent style instead of mixing package-qualified and unqualified styles.
This fixes a test failure with Clozure CL. The order of items returned by hash-table-keys is implementation-defined.
fjl
changed the title
|
Thanks for working on access. Great to see a lower number of dependencies. What's the portability fix? (@maintainer: the diff is large because of indentation fixes) |
|
The portability thing is sorting the result of hash-table-keys. |
|
Thank you to the contributors here I don't do any common lisp these days unfortunately so its great to see you folks who are interested are contributing. If either of you wish to be maintainers of this project, please let me know. I would rather the project move forward than be stagnated by my lack of language use. Alternatively, please feel free to submit a patch updating the documentation to note that you are contributors, should you want such attribution. |
It looks like 'access' has already been forked to the 'sharplispers' org: https://github.com/sharplispers/access This org takes care of unmaintained CL projects which are important to the well-being of the quicklisp dependency graph. I will open an issue there regarding this. If they agree, and you do too, the project could be transferred properly. |
Merge this after #14
This removes the dependency on 'anaphora' because access only uses basic AIF / AWHEN, and these can easily be replaced by alexandria's IF-LET / WHEN-LET helpers. Just one less dependency to worry about.
The PR also includes a bunch of other fixes related to package definitions and a fix for a portability issue. I'm sorry for just dumping all of these changes in here, but please consider that you'd have to review many more PRs if I had split this up.