Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/730 feature execute query command #919

Merged
merged 37 commits into from
Jun 1, 2023

Conversation

phjulia
Copy link
Collaborator

@phjulia phjulia commented May 21, 2023

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@github-actions
Copy link

github-actions bot commented May 21, 2023

Coverage Report

Commit: eac61c1
Base: develop@f3d3f78

Type Base This PR
Total Statements Coverage  41.63%  41.81%  (+0.18%)
Total Branches Coverage  33.37%  33.69%  (+0.32%)
Total Functions Coverage  47.93%  48.09%  (+0.16%)
Total Lines Coverage  41.59%  41.75%  (+0.16%)
Details (changed testable files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/index.js  42.9%  39.23%  48%  42.9%
lib/metadataTypes/MetadataType.js  61.17%  60.79%  71.08%  60.94%
lib/metadataTypes/Query.js  87.77%  70%  95.23%  88.5%

@JoernBerkefeld JoernBerkefeld linked an issue May 22, 2023 that may be closed by this pull request
@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" c/query COMPONENT labels May 22, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.1.0 milestone May 22, 2023
@JoernBerkefeld JoernBerkefeld changed the title 730 feature execute query command Feature/730 feature execute query command May 24, 2023
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good code but needs a few changes before we can merge it :)

lib/index.js Show resolved Hide resolved
lib/metadataTypes/MetadataType.js Show resolved Hide resolved
lib/cli.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/metadataTypes/MetadataType.js Show resolved Hide resolved
lib/metadataTypes/Query.js Show resolved Hide resolved
lib/metadataTypes/MetadataType.js Outdated Show resolved Hide resolved
test/type.query.test.js Outdated Show resolved Hide resolved
test/type.query.test.js Outdated Show resolved Hide resolved
phjulia and others added 6 commits May 24, 2023 19:03
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
lib/index.js Outdated Show resolved Hide resolved
@JoernBerkefeld
Copy link
Contributor

good to merge now!
let me sort if we should go for 5.1.0 already and then merge it eventually

@JoernBerkefeld JoernBerkefeld merged commit 3e54f4a into develop Jun 1, 2023
4 checks passed
@JoernBerkefeld JoernBerkefeld deleted the 730-feature-execute-query-command branch June 1, 2023 09:47
@JoernBerkefeld JoernBerkefeld mentioned this pull request Jun 5, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/query COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] execute query command
2 participants