Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/207: dont create logfile when running helper methods + bugfix/969: log not truncated during test execution #971

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jun 6, 2023

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • n/a test scripts updated
  • Wiki updated (via PR Release 5.1.0 #961 )

@JoernBerkefeld JoernBerkefeld added this to the 5.1.0 milestone Jun 6, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jun 6, 2023
@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage Report

Commit: e5c2295
Base: develop@d3dd9d5

Type Base This PR
Total Statements Coverage  45.99%  46.04%  (+0.05%)
Total Branches Coverage  36.73%  36.98%  (+0.25%)
Total Functions Coverage  53.02%  52.89%  (-0.13%)
Total Lines Coverage  45.91%  45.96%  (+0.05%)
Details (changed testable files):
File Statements Branches Functions Lines
lib/Deployer.js  64.64%  55.67%  71.42%  65%
lib/cli.js  0%  0%  0%  0%
lib/index.js  43.85%  39.71%  52%  43.85%
lib/util/util.js  59.56%  50%  75.55%  58.92%

@JoernBerkefeld JoernBerkefeld changed the title bugfix/207: dont create logfile when running helper methods bugfix/207: dont create logfile when running helper methods + bugfix/969: log not truncated during test execution Jun 6, 2023
@JoernBerkefeld
Copy link
Contributor Author

wiki

https://github.com/Accenture/sfmc-devtools/wiki/07.-Advanced-Configuration/_edit

--api=[log|api]

Optionally, you can see API requests & responses in the logfile or directly in CLI.

Examples:

mcdev retrieve --api=log
mcdev deploy --api=cli

--noLogFile

Optionally, you can disable creating the 2 logfiles when running mcdev.

Examples:

mcdev retrieve --noLogFile
mcdev deploy --noLogFile

@JoernBerkefeld JoernBerkefeld mentioned this pull request Jun 6, 2023
1 task
@JoernBerkefeld JoernBerkefeld merged commit 247752a into develop Jun 6, 2023
7 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/207-logs-folder-automatically-created branch June 6, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] log in cli is truncated if too many log entries happen fast [BUG] Logs folder automatically created
1 participant