Dev 22129 definable ingress class ingress.tpl #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressClassName was provided
|
@bradsoper this is a feature request that’s require changes across the stack. Operator, RoR web app, and more. I would suggest to open a issue and discuss it mainly with product. |
|
Understood, I see now we do define the ingressClassName in the app as well. I will discuss with product. Thank you |
…n ingress routes created by the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some customers have multiple ingressClasses. They need a way to define the ingressClassName for the ingress objects. This PR will add the ability to define the ingressClass. If no ingressClassName is defined it will take the default ingressClass.
This will also fix the issue we have with the ingress objects being hardcoded to the ingressClassName 'nginx'
Here is the dev ticket:
https://cnvrgio.atlassian.net/browse/DEV-22129