Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites! Favorites evrywhere! #24

Merged
merged 1 commit into from Jul 23, 2015
Merged

Favorites! Favorites evrywhere! #24

merged 1 commit into from Jul 23, 2015

Conversation

nugged
Copy link
Contributor

@nugged nugged commented Jul 23, 2015

Fav-button everywhere: near every talk on user page and on schedule page, near unscheduled talks.

Favorites everywhere!

Disclaimer: you can take only few ;-). But really, try all: it's ok.

Fav-button everywhere: near every talk on user page and on schedule page, near unscheduled talks.

![Favorites everywhere!](https://i.imgflip.com/oky8w.jpg "Favorites! Favorites everywhere!")
JJ added a commit that referenced this pull request Jul 23, 2015
@JJ JJ merged commit e349340 into Act-Conferences:master Jul 23, 2015
@nugged
Copy link
Contributor Author

nugged commented Jul 23, 2015

There's also was two issues, one I updated: #25
and second is when owner of task adds that task to his 'attending task', so it appear twice on user page, visitor (for example, me) can press "fav" button there and there and toggle state TWICE for favoring, disabling it (but our site shows that it become selected). That because I (we) have only one ajax handler: updatemytalks_a.

I created anther one handler updatemytalks_as in book/Act fork (there is also big description in commit):
https://github.com/nugged/Act/commit/ee0934f14c54f33e9c147cad0348133fd09e4ba5
book/Act#62
but I don't now can it be pulled or I should forget, ... anyway. FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants