Added updatemytalks_as private handler and sub ajax_stateful_handler #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'updatemytalks_as' for ajax_stateful_handler to specifically set or clean user's favorite task, not to toggle. On some pages of YAPC::EU::2015 there is few 'favorite' buttons for same task, and when they both off and visitor presses them one-by-one, they both become toggled to 'on' state, but two in a row request to old updatemytalks_a handler toggles task in favorites from off to on and back to off. So we need separate handler: * updatemytalks_a -> toggles by 'task_id' in request. * updatemytalks_as -> sets 'task_id' favorite state depending from additional 'state' parameter For latter one we already provide preparations in javascript already, there: https://github.com/Act-Conferences/ye2015/blob/master/wwwdocs/js/main.js#L22-L26
This was referenced Jul 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'updatemytalks_as' for ajax_stateful_handler to specifically set or clean user's
favorite task, not to toggle.
On some pages of YAPC::EU::2015 there is few 'favorite' buttons for same task,
and when they both off and visitor presses them one-by-one, they both become
toggled to 'on' state, but two in a row request to old updatemytalks_a handler
toggles task in favorites from off to on and back to off.
So we need separate handler:
For latter one we already provide preparations in javascript already, there:
https://github.com/Act-Conferences/ye2015/blob/master/wwwdocs/js/main.js#L22-L26