Fix ree tests failing #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balvig
force-pushed
the
jb/fix-ree-tests-failing
branch
from
8fffa6c
to
913e784
Compare
balvig
added a commit
that referenced
this pull request
Oct 11, 2023
## What Alternate workaround to #135 and #143. ## Why While there still seems to be an [issue with `add_mail` "clearing" `body`,](mikel/mail#1539) instead of locking the gem for all ruby version and making it difficult to test newer ones, we can limit the version restrictions to legacy version and use this workaround of flipping the order for Ruby 2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes ree-1.8.7 failing with the following error message:
How
Locks the
mini_mimedependency ofmailto a slightly older version.Both of them are development dependencies.
The issue in #135 is still a blocker.