Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Target Automation #447

Open
WillStrohl opened this issue Jun 23, 2019 · 3 comments
Open

Link Target Automation #447

WillStrohl opened this issue Jun 23, 2019 · 3 comments

Comments

@WillStrohl
Copy link

Assuming that someone can get links to work... (See Issue #437 )

The link should automatically be parsed and, if the domain is not in the list of HTTP aliases for the current site/portal, the link should automatically include a _blank target.

Along the same lines, I think a good option as a setting/preference would be to also include the option for an administrator to specify whether a nofollow attribute is also added to external links.

@Timo-Breumelhof
Copy link

That is already in working for all auto links

const string outSite = "<a href=\"{0}\" target=\"_blank\" rel=\"nofollow\">{1}</a>";

It might be better to split that function up and parse all links for target="_blank" and "nofollow"

@Timo-Breumelhof
Copy link

I guess the idea was "if you allow your users to create their own links..."

@Timo-Breumelhof
Copy link

Timo-Breumelhof commented Jul 5, 2019

AutoLink code strips all <a> tags and then re-inserts them.
If needed adding _blank and nofollow
(so all links will be like that, AFAIK there are no settings for this)

artfuld added a commit that referenced this issue Jul 5, 2019
…automation-issue

Issues/#447 link target automation issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants