Revert embedding ldflags in GOFLAGS, it's not supported yet

golang/go#26849

activestate.yaml

@@ -4,7 +4,8 @@ scripts:
     description: The environment settings used throughout our project
     value: |
       CLI_PKGS=./state
-      GOFLAGS='-mod=vendor -ldflags="-s -w"'
+      CLI_BUILDFLAGS='-ldflags="-s -w"'
+      GOFLAGS='-mod=vendor'
       GOPATH="${GOPATH:=`go env GOPATH`}"
       GOROOT="${GOROOT:=`go env GOROOT`}"
       PATH="${GOROOT}/bin:${GOPATH}/bin:${PATH}"
@@ -23,21 +24,21 @@ scripts:
     description: Builds the project. Note by default this targets the staging environment, to target prod use `APIENV=prod`.
     value: |
       $scripts.preprocess
-      eval go build -o ./build/$BUILD_NAME $CLI_PKGS
+      eval go build -o ./build/$BUILD_NAME $CLI_BUILDFLAGS $CLI_PKGS
       mkdir -p public/update
       go run scripts/update-generator/main.go -o public/update ./build/$BUILD_NAME
   - name: build-external
     description: Builds the project for external use (limiting its feature-set). Note by default this targets the staging environment, to target prod use `APIENV=prod`.
     value: |
       $scripts.preprocess
-      eval go build -tags external -o ./build/$BUILD_NAME $CLI_PKGS
+      eval go build -tags external -o ./build/$BUILD_NAME $CLI_BUILDFLAGS $CLI_PKGS
       mkdir -p public/update
       go run scripts/update-generator/main.go -o public/update ./build/$BUILD_NAME
   - name: install
     description: Installs the current HEAD version into GOBIN
     value: |
       $scripts.preprocess
-      eval go install $CLI_PKGS
+      eval go install $CLI_BUILDFLAGS $CLI_PKGS
   - name: deploy-updates
     description: Deploys update files to S3. This steps is automated by CI and should never be ran manually unless you KNOW WHAT YOU'RE DOING.
     constraints: