Fix potential watcher panic #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
May 5, 2022
•
MDrakos
commented
 DX-920 Service panics (rtwatcher) when hosting activation
|
Naatan
approved these changes
May 5, 2022
| @@ -19,3 +21,24 @@ func TestWatcher_ticker(t *testing.T) { | |||
| }) | |||
| require.Equal(t, 10, calls) | |||
| } | |||
|
|
|||
| func TestWatcher_check(t *testing.T) { | |||
There was a problem hiding this comment.
Love to see these types of fixes accompanied by a simple test :)
Naatan
pushed a commit
that referenced
this pull request
May 26, 2022
Fix potential watcher panic # Conflicts: # cmd/state-svc/internal/rtwatcher/watcher.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.