Remove IsAdmin() environment variable override #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the base branch from
version/0-36-0-RC1
to
version/0-36-0-RC1
mitchell-as
changed the title
mitchell-as
changed the title
Naatan
requested changes
Nov 8, 2022
Comment on lines
217
to
218
| // Note: on Windows, runtimes are not installed to the Admin %PATH%, even if the user has admin | ||
| // privileges, so call CleanUserEnv with user scope. |
There was a problem hiding this comment.
This doesn't sound right to me. We pass isAdmin to WriteUserEnv(), and it's respected there.
If CleanUserEnv() doesn't handle this input the same as WriteUserEnv() then we should address that head-on. The current change feels like we're working around the issue from the consuming code, which is error-prone.
There was a problem hiding this comment.
After investigation, it was a bug in ConfigureAvailableShells. Thanks for suggesting something was amiss.
|
I checked the other calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtimes are not installed to the admin
%PATH%even if the user has admin privileges (which is the case on CI), so when uninstalling the runtime, the user scope needs to be used. Previously, the environment variable would overrideIsAdmin()to returnfalseon CI (and thus uninstall with user scope despite having admin privileges).