Initial dotprogress indicator for non-interactive mode. #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Mar 13, 2023
•
mitchell-as
commented
 DX-1449 Runtime progress has a non-interactive mode
|
mitchell-as
force-pushed
the
mitchell/dx-1449
branch
2 times, most recently
from
3ba568f
to
80b38be
Compare
mitchell-as
force-pushed
the
mitchell/dx-1449
branch
from
80b38be
to
17c9c2b
Compare
daved
approved these changes
Mar 14, 2023
| @@ -55,7 +55,7 @@ func initOutput(flags outputFlags, formatName string, shellName string) (output. | |||
| OutWriter: os.Stdout, | |||
| ErrWriter: os.Stderr, | |||
| Colored: !flags.DisableColor(), | |||
| Interactive: term.IsTerminal(int(os.Stdin.Fd())), | |||
| Interactive: !flags.NonInteractive && term.IsTerminal(int(os.Stdin.Fd())), | |||
There was a problem hiding this comment.
I'd like to verify that this conditional is consciously different than the "isInteractive" variable in the main.go file. Normally it is nice to calculate this value once, then pass it around to all interested locations.
There was a problem hiding this comment.
I've created a ticket for this question: https://activestatef.atlassian.net/browse/DX-1667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.