Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Spring cloud stream functional bindings + functional channel bindings configuration #875

Conversation

LorenzoDiGiuseppe
Copy link
Contributor

@LorenzoDiGiuseppe LorenzoDiGiuseppe commented Jan 26, 2023

This PR fixes Activiti/Activiti#4196 replacing the deprecated annotations from spring-cloud-stream with the new functional one provided by spring-cloud-function.

The annotation @StreamListener and @EnableBindings has been replaced with custom annotations defined in Activiti-Cloud#983:

  • @FunctionalBinding
  • @ConditionalFunctionalBinding
  • @ConnectorBinding

This PR additionally migrates input and output bindings to the approach defined in Activiti/activiti-cloud#983.

@jsokolowskii jsokolowskii force-pushed the AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview branch 2 times, most recently from 85e426b to c3f0e68 Compare January 27, 2023 12:09
@LorenzoDiGiuseppe LorenzoDiGiuseppe force-pushed the AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview branch from f80cc8e to 2df5e7a Compare January 27, 2023 13:57
@jsokolowskii jsokolowskii changed the title Add support for functional channel bindings configuration Spring cloud stream functional bindings + functional channel bindings configuration Jan 30, 2023
@jsokolowskii jsokolowskii marked this pull request as ready for review January 30, 2023 08:51
Copy link
Member

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LorenzoDiGiuseppe LorenzoDiGiuseppe force-pushed the AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview branch from 3a1a31f to 6647778 Compare January 30, 2023 12:44
@LorenzoDiGiuseppe LorenzoDiGiuseppe merged commit 242d10f into develop Jan 30, 2023
@LorenzoDiGiuseppe LorenzoDiGiuseppe deleted the AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview branch January 30, 2023 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change enhancement New feature or request
Projects
None yet
3 participants