This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Spring cloud stream functional bindings + functional channel bindings configuration #875
Merged
LorenzoDiGiuseppe
merged 37 commits into
develop
from
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
Jan 30, 2023
Merged
Spring cloud stream functional bindings + functional channel bindings configuration #875
LorenzoDiGiuseppe
merged 37 commits into
develop
from
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsokolowskii
force-pushed
the
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
branch
2 times, most recently
from
January 27, 2023 12:09
85e426b
to
c3f0e68
Compare
LorenzoDiGiuseppe
requested review from
igdianov,
erdemedeiros and
jsokolowskii
January 27, 2023 13:26
LorenzoDiGiuseppe
force-pushed
the
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
branch
from
January 27, 2023 13:57
f80cc8e
to
2df5e7a
Compare
jsokolowskii
changed the title
Add support for functional channel bindings configuration
Spring cloud stream functional bindings + functional channel bindings configuration
Jan 30, 2023
erdemedeiros
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit 9b257de.
LorenzoDiGiuseppe
force-pushed
the
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
branch
from
January 30, 2023 12:44
3a1a31f
to
6647778
Compare
LorenzoDiGiuseppe
deleted the
AAE-6608-functional-channel-bindings-dev-ldigiuseppe-jsokol-preview
branch
January 30, 2023 13:24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Activiti/Activiti#4196 replacing the deprecated annotations from
spring-cloud-stream
with the new functional one provided byspring-cloud-function
.The annotation
@StreamListener
and@EnableBindings
has been replaced with custom annotations defined in Activiti-Cloud#983:@FunctionalBinding
@ConditionalFunctionalBinding
@ConnectorBinding
This PR additionally migrates input and output bindings to the approach defined in Activiti/activiti-cloud#983.