-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring cloud stream functional bindings + functional channel bindings configuration #983
Merged
LorenzoDiGiuseppe
merged 101 commits into
develop
from
dev-jsokolowski-test-functional-binding-build-preview
Jan 30, 2023
Merged
Spring cloud stream functional bindings + functional channel bindings configuration #983
LorenzoDiGiuseppe
merged 101 commits into
develop
from
dev-jsokolowski-test-functional-binding-build-preview
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly have no subscribers
LorenzoDiGiuseppe
force-pushed
the
dev-jsokolowski-test-functional-binding-build-preview
branch
from
January 27, 2023 12:26
c5fc51e
to
ce7ce67
Compare
jsokolowskii
changed the title
test functional binding build preview
Spring cloud stream functional bindings + functional channel bindings configuration
Jan 30, 2023
jsokolowskii
requested review from
igdianov,
LorenzoDiGiuseppe,
erdemedeiros and
VitoAlbano
January 30, 2023 08:54
erdemedeiros
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LorenzoDiGiuseppe
deleted the
dev-jsokolowski-test-functional-binding-build-preview
branch
January 30, 2023 11:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Activiti/Activiti#4196 and Activiti/Activiti#3764 replacing the deprecated annotations from
spring-cloud-stream
with the new functional one provided byspring-cloud-function
.The annotation
@StreamListener
and@EnableBindings
has been replaced with custom annotations:@FunctionalBinding
@ConditionalFunctionalBinding
@ConnectorBinding
The PR introduces also some
BeanPostProcessor
for changing the binding configuration for the new annotations, while preserving the existing properties that are used byRabbitMQ
andKafka
binder.Existing interfaces declaring a
MessageChannel
have been implemented by beans that expose internal channels for backward compatibility with legacy code.IntegrationFlows
have been changed for using gateway interfaces that allows binding with the new functional approach.This PR additionally migrates input and output bindings.