Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring cloud stream functional bindings + functional channel bindings configuration #983

Merged

Conversation

jsokolowskii
Copy link
Contributor

@jsokolowskii jsokolowskii commented Jan 27, 2023

This PR fixes Activiti/Activiti#4196 and Activiti/Activiti#3764 replacing the deprecated annotations from spring-cloud-stream with the new functional one provided by spring-cloud-function.

The annotation @StreamListener and @EnableBindings has been replaced with custom annotations:

  • @FunctionalBinding
  • @ConditionalFunctionalBinding
  • @ConnectorBinding

The PR introduces also some BeanPostProcessor for changing the binding configuration for the new annotations, while preserving the existing properties that are used by RabbitMQ and Kafka binder.

Existing interfaces declaring a MessageChannel have been implemented by beans that expose internal channels for backward compatibility with legacy code.

IntegrationFlows have been changed for using gateway interfaces that allows binding with the new functional approach.

This PR additionally migrates input and output bindings.

LorenzoDiGiuseppe and others added 30 commits January 27, 2023 13:26
@LorenzoDiGiuseppe LorenzoDiGiuseppe force-pushed the dev-jsokolowski-test-functional-binding-build-preview branch from c5fc51e to ce7ce67 Compare January 27, 2023 12:26
@jsokolowskii jsokolowskii changed the title test functional binding build preview Spring cloud stream functional bindings + functional channel bindings configuration Jan 30, 2023
@jsokolowskii jsokolowskii added enhancement New feature or request breaking-change labels Jan 30, 2023
@jsokolowskii jsokolowskii marked this pull request as ready for review January 30, 2023 08:54
Copy link
Member

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LorenzoDiGiuseppe LorenzoDiGiuseppe merged commit 328f4a8 into develop Jan 30, 2023
@LorenzoDiGiuseppe LorenzoDiGiuseppe deleted the dev-jsokolowski-test-functional-binding-build-preview branch January 30, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple from Spring Cloud Stream
4 participants