Decouple AAE from spring-cloud-stream #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
from
4586e7a
to
ca1d40b
Compare
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
from
f487156
to
a8a7bc1
Compare
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
2 times, most recently
from
8a917cd
to
b83f376
Compare
jsokolowskii
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
from
483bd2e
to
69ae50d
Compare
LorenzoDiGiuseppe
changed the title
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
2 times, most recently
from
9be7afa
to
0b94fde
Compare
LorenzoDiGiuseppe
changed the title
LorenzoDiGiuseppe
changed the title
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
from
b190863
to
12e3e02
Compare
erdemedeiros
reviewed
Jan 6, 2023
There was a problem hiding this comment.
Great job @LorenzoDiGiuseppe and @jsokolowskii ! This task was pending for a while.
A part from some minor details, it looks good to me.
...src/test/java/org/activiti/cloud/notifications/graphql/config/EngineEventsConfiguration.java
Show resolved
Hide resolved
...ava/org/activiti/cloud/services/events/configuration/ProcessEngineChannelsConfiguration.java
Outdated
Show resolved
Hide resolved
...java/org/activiti/cloud/common/messaging/config/ConditionalFunctionBindingConfiguration.java
Outdated
Show resolved
Hide resolved
...est/java/org/activiti/cloud/common/messaging/config/test/FunctionBindingConfigurationIT.java
Outdated
Show resolved
Hide resolved
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
2 times, most recently
from
01f9fb7
to
0b4e50c
Compare
LorenzoDiGiuseppe
force-pushed
the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
from
dc80d97
to
ac621e5
Compare
LorenzoDiGiuseppe
deleted the
aae-6608-functional-stream-cloud-dev-ldigiuseppe-jsokolowski-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Activiti/Activiti#4196 and Activiti/Activiti#3764 replacing the deprecated annotations from
spring-cloud-streamwith the new functional one provided byspring-cloud-function.The annotation
@StreamListenerand@EnableBindingshas been replaced with custom annotations:@FunctionalBinding@ConditionalFunctionalBinding@ConnectorBindingThe PR introduces also some
BeanPostProcessorfor changing the binding configuration for the new annotations, while preserving the existing properties that are used byRabbitMQandKafkabinder.Existing interfaces declaring a
MessageChannelhave been implemented by beans that expose internal channels for backward compatibility with legacy code.IntegrationFlowshave been changed for using gateway interfaces that allows binding with the new functional approach.