fix: replace webbrowser.open with xdg-open with original LD_LIBRARY_PATH #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johan-bjareholt
force-pushed
the
dev/fix-buggy-webbrowser-open
branch
2 times, most recently
from
db6a834
to
9ac3d98
Compare
|
Could someone who has this issue try either to build this PR from source and package it with PyInstaller or try out this pre-built package? |
This was referenced Jun 25, 2020
ErikBjare
reviewed
Jun 25, 2020
| def open_webui(root_url): | ||
| print("Opening dashboard") | ||
| webbrowser.open(root_url) |
There was a problem hiding this comment.
This will fail on every OS except those with xdg-open. Should probably add a check for that and fall back to using webbrowser.
|
I'm happy to tell you that it works on my machine. I'm not sure about what version information you need. Anyway, here's something you may find useful. |
johan-bjareholt
force-pushed
the
dev/fix-buggy-webbrowser-open
branch
from
9ac3d98
to
bcd27a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #20 and ActivityWatch/activitywatch#208