fix: update to pyqt6 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
force-pushed
the
Bump-pyqt
branch
from
c03958b
to
bf75c90
Compare
|
Thanks for this @maciekstosio! I just received my M2 Air yesterday, so finally getting around to merging this. |
|
This pull request fixes 1 alert when merging bf75c90 into 730575b - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first open source PR, so if I did anything wrong, let me know I'll fix it. I've seen that there is open wip pr for PyQt6 (as far as I understand loading resources blocks it, but it seems to work on m1 mac, unfortunately can't test it on other platforms), but in this one I fixed also some errors/warnings that I got. The bump was necessary to make it work on mac with m1.