Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect modules #27

Closed
wants to merge 6 commits into from
Closed

Autodetect modules #27

wants to merge 6 commits into from

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Aug 30, 2017

This is a nice one.

  • Detects modules in the users PATH (executables must contain "aw-")
  • Detects modules bundled with aw-qt (in the same directory)

This makes it a lot easier to run manage whichever module/watcher you want with aw-qt.

@ErikBjare
Copy link
Member Author

I'm probably going to go ahead and merge this when the macOS build is done.

@ErikBjare
Copy link
Member Author

ErikBjare commented Sep 1, 2017

I just realized that PyInstaller might mess up when you try to run system modules since it modifies LD_LIBRARY_PATH either directly or indirectly (since its likely to search the working directory).

  • Check that it handles system modules properly

@ErikBjare
Copy link
Member Author

  • Also, should probably test this on Windows where things might behave differently.



def _discover_modules_system() -> List[str]:
search_paths = os.environ["PATH"].split(":")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PATH might not be defined on Windows

@sanderboom
Copy link

This would be a sweet addition!

I'm probably going to go ahead and merge this when the macOS build is done.

And it was almost done? What's the holdup? Should I test under Window$?

@ErikBjare
Copy link
Member Author

Yeah testing on Windows (and macOS, but should be fine) is the blocker.

@ErikBjare
Copy link
Member Author

Closing in favor of #56

@ErikBjare ErikBjare closed this Apr 19, 2020
vasuemme111 pushed a commit to dholendar-27/aw-qt that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants