-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to database required for syncing #61
Comments
Maybe look at the schema version and if the schema version is not the same as the current one we should make a user-visible warning that the db from another instance is older/newer?
Agreed! |
Maybe also make a unique identifier for each computer? I'd prefer using hostname because it's more human readable, but I can also see the issue with it so my stance on that question is neutral. |
I realized that the whole mpsc thread model is a bit excessive if we are to only have read access to the database, so I rewrote the datastore code to be able to more nicely work without the worker. I would suggest to adapt the syncing code to create a read-only SQLite connection itself instead of going through the worker by only using the DatastoreInstance. |
I think we should at some point as people have already had issues with this (https://forum.activitywatch.net/t/remove-host-computer/358). Syncthing does it by generating a GUID for every host, possibly derived from the hosts public key. I opened an issue about it: ActivityWatch/activitywatch#302 |
Fixed in #76 |
I appreciate it, but I kinda think that the solution you proposed was better (and is how Syncthing deals with nodes of different versions):
|
If you look at the change you can see that this does both, the added "migrate_enabled" parameter does the following:
|
A couple of things:
Thoughts @johan-bjareholt?
The text was updated successfully, but these errors were encountered: