Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aw-query: Add preprocessing and refcounting #183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johan-bjareholt
Copy link
Member

A very unsophisticated way to refcount.

TODO:

  • Lots of TODOs in code
  • Value is cloned even if variable is overwritten
  • Run more benchmarks

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #183 into master will decrease coverage by 8.70%.
The diff coverage is 19.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   59.07%   50.36%   -8.71%     
==========================================
  Files          58       60       +2     
  Lines        7707     8146     +439     
  Branches     2311     1537     -774     
==========================================
- Hits         4553     4103     -450     
- Misses       3104     4031     +927     
+ Partials       50       12      -38     
Impacted Files Coverage Δ
aw-query/src/preprocess.rs 0.00% <0.00%> (ø)
aw-query/src/varenv.rs 0.00% <0.00%> (ø)
aw-query/src/lib.rs 27.50% <20.00%> (-20.33%) ⬇️
aw-query/src/interpret.rs 59.90% <42.85%> (-20.62%) ⬇️
aw-query/tests/query.rs 69.58% <55.55%> (-22.06%) ⬇️
aw-query/src/functions.rs 91.69% <100.00%> (-0.29%) ⬇️
aw-query/src/lexer.rs 33.89% <0.00%> (-57.07%) ⬇️
aw-query/src/parser.rs 27.45% <0.00%> (-18.78%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc85f3...e43829b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant