Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added hostname filtering support to find_bucket #242

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jun 8, 2021

This functionality was available in aw-core.

Needed for new queries which don't assume a certain bucket ID containing the hostname.

Also needed for my PR in ErikBjare/quantifiedme#4

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #242 (b7da36e) into master (4a1943a) will increase coverage by 0.13%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   60.35%   60.48%   +0.13%     
==========================================
  Files          44       44              
  Lines        5027     5036       +9     
==========================================
+ Hits         3034     3046      +12     
+ Misses       1993     1990       -3     
Impacted Files Coverage Δ
aw-query/src/functions.rs 84.45% <54.54%> (+1.25%) ⬆️
aw-transform/src/find_bucket.rs 73.33% <77.77%> (-6.67%) ⬇️
aw-datastore/src/datastore.rs 78.56% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1943a...b7da36e. Read the comment docs.

@ErikBjare
Copy link
Member Author

@johan-bjareholt I'm going to go ahead and merge this. But please review, there might very well be better ways to do things.

@ErikBjare ErikBjare merged commit 7ad9512 into master Jun 8, 2021
@ErikBjare ErikBjare deleted the dev/find-bucket-hostname branch June 8, 2021 17:26
@ErikBjare ErikBjare mentioned this pull request Jun 9, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant