Make watcher shutdown as aw-qt parent process dies. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! 👍 Are committing with another user than on GitHub or did someone else do the commits? Personally I don't care since it looks great anyway, but next time if you want to top the contributors list I would recommend setting your email in your git config to the same as your github account so the commits are linked to you.
No problem, it's a small PR so i can just squash and merge so they look like one complete commit later :) |
johan-bjareholt
approved these changes
Jul 19, 2017
|
Just a note: This has the same issue with PyInstaller as I mentioned in ActivityWatch/aw-watcher-afk#24 |
|
It's me, holding on wrong config files (fixed now). Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActivityWatch/aw-qt#19
This makes the child process (the watcher) check it's PPID, so that if ever its parent process dies (aw-qt), this one shutdowns also. 1 is
PPIDof init process, what PPIDs get set to when parents die (aka "the orphanage").Sorry for the commit fluff, git still gets the better of me.