Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle date clearing in Activity view #554

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Apr 8, 2024

Fixes ActivityWatch/activitywatch#1023

Improved date validation in the Activity view by checking if the date is valid using moment.js before proceeding with date manipulations. This prevents errors when the date is cleared or invalid.

@ErikBjare
Copy link
Member

Sorry for the slow review.
Looks good! Waiting for CI to pass.

@ErikBjare ErikBjare merged commit 97a1089 into ActivityWatch:master May 1, 2024
7 checks passed
@pkvach pkvach deleted the dev/fix-date-clearing-in-activity-view branch May 2, 2024 04:52
@pkvach
Copy link
Contributor Author

pkvach commented May 2, 2024

No problem at all. Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date "Clear" results in internal error
2 participants